Change in osmocom-bb[master]: layer23: Use osmo_sock_unix_init_ofd() from libosmocore

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Sep 6 13:16:58 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10805 )

Change subject: layer23: Use osmo_sock_unix_init_ofd() from libosmocore
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/10805/1/src/host/layer23/src/common/sap_interface.c
File src/host/layer23/src/common/sap_interface.c:

https://gerrit.osmocom.org/#/c/10805/1/src/host/layer23/src/common/sap_interface.c@a516
PS1, Line 516: 
Shouldn't we keep this?


https://gerrit.osmocom.org/#/c/10805/1/src/host/layer23/src/common/sap_interface.c@503
PS1, Line 503: 	rc = osmo_sock_unix_init_ofd(&ms->sap_wq.bfd, SOCK_STREAM, 0, socket_path, OSMO_SOCK_F_CONNECT);
It seems the include is missing...



-- 
To view, visit https://gerrit.osmocom.org/10805
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57c724c78dbbbce0546ebe914e370f32c8c89703
Gerrit-Change-Number: 10805
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 06 Sep 2018 13:16:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180906/61907064/attachment.htm>


More information about the gerrit-log mailing list