Change in osmo-bsc[master]: codec_pref: Log HR2 specifically as never specified

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Sep 4 17:43:42 UTC 2018


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/10756 )

Change subject: codec_pref: Log HR2 specifically as never specified
......................................................................

codec_pref: Log HR2 specifically as never specified

Change-Id: Ia7d6545710b4bf609c2872e13dcb3b44abfc604e
---
M src/osmo-bsc/codec_pref.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c
index 212c2a6..cbe8ef4 100644
--- a/src/osmo-bsc/codec_pref.c
+++ b/src/osmo-bsc/codec_pref.c
@@ -35,7 +35,6 @@
 	case GSM0808_PERM_FR1:
 		return GSM48_CMODE_SPEECH_V1;
 		break;
-	case GSM0808_PERM_HR2:
 	case GSM0808_PERM_FR2:
 		return GSM48_CMODE_SPEECH_EFR;
 		break;
@@ -43,6 +42,8 @@
 	case GSM0808_PERM_FR3:
 		return GSM48_CMODE_SPEECH_AMR;
 		break;
+	case GSM0808_PERM_HR2:
+		LOGP(DMSC, LOGL_FATAL, "Speech HR2 was never specified!\n");
 	default:
 		LOGP(DMSC, LOGL_FATAL, "Unsupported permitted speech %s selected, "
 		     "assuming AMR as channel mode...\n",

-- 
To view, visit https://gerrit.osmocom.org/10756
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7d6545710b4bf609c2872e13dcb3b44abfc604e
Gerrit-Change-Number: 10756
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180904/998531f4/attachment.htm>


More information about the gerrit-log mailing list