Change in osmo-mgw[master]: fix mgcp_verify_ci(): off-by-one in max len check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Sep 4 17:43:07 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10754 )

Change subject: fix mgcp_verify_ci(): off-by-one in max len check
......................................................................


Patch Set 1: Code-Review+2

I think the proper approach is to have MAXLEN to be 32 and only use MAXLEN+1 when sizing the array. But well, up to you.


-- 
To view, visit https://gerrit.osmocom.org/10754
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d6cc96be252bb486e94f343a8c7cae641ff9429
Gerrit-Change-Number: 10754
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Tue, 04 Sep 2018 17:43:07 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180904/64721003/attachment.htm>


More information about the gerrit-log mailing list