Change in osmo-sgsn[master]: gprs_gmm: introduce a GMM Attach Request FSM

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9257 )

Change subject: gprs_gmm: introduce a GMM Attach Request FSM
......................................................................


Patch Set 15: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/9257/15/include/osmocom/sgsn/gprs_gmm_attach.h
File include/osmocom/sgsn/gprs_gmm_attach.h:

https://gerrit.osmocom.org/#/c/9257/15/include/osmocom/sgsn/gprs_gmm_attach.h@8
PS15, Line 8: enum gmm_attach_req_fsm_states {
if those states are modelled after any spec reference, it might be useful to document it here in a comment.


https://gerrit.osmocom.org/#/c/9257/15/src/gprs/gprs_gmm_attach.c
File src/gprs/gprs_gmm_attach.c:

https://gerrit.osmocom.org/#/c/9257/15/src/gprs/gprs_gmm_attach.c@2
PS15, Line 2: 
please put the usual license header on top o the file, simply copying it from a neighboring file


https://gerrit.osmocom.org/#/c/9257/15/src/gprs/gprs_gmm_attach.c@387
PS15, Line 387: static __attribute__((constructor)) void l2tp_fsm_init(void)
l2tp ?



-- 
To view, visit https://gerrit.osmocom.org/9257
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58b9c17be9776a03bb2a5b21e99135cfefc8c912
Gerrit-Change-Number: 9257
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Tue, 04 Sep 2018 17:30:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180904/69fe48f8/attachment.htm>