Change in osmo-ttcn3-hacks[master]: L3_Common: extend the AuthVector to contain ATUS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Sep 4 17:17:45 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10767 )

Change subject: L3_Common: extend the AuthVector to contain ATUS
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/10767/3/library/L3_Common.ttcn
File library/L3_Common.ttcn:

https://gerrit.osmocom.org/#/c/10767/3/library/L3_Common.ttcn@15
PS3, Line 15: 	OCT14 auts
> does it really make sense to store the AUTS value as part of the vector?  Isn't AUTS computed someho […]
Ok, after reading the test case I understand how it's used.  However, it still feels odd.  I suggest to put a comment here in the source stating that the AUTS value isn't strictly part of the tuple (as per 3GPP meaning of an authentication vector/quintuple) but that we nonetheless use this field here to make sure we use the same auts value both on the GSUP and on the L3 side.



-- 
To view, visit https://gerrit.osmocom.org/10767
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1afa47778e6220cab375ae4b54b251801724fdb
Gerrit-Change-Number: 10767
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Tue, 04 Sep 2018 17:17:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180904/d881146b/attachment.htm>


More information about the gerrit-log mailing list