Change in osmo-bts[master]: measurement: fix SACCH interval remapping in test_is_meas_overdue()

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10760 )

Change subject: measurement: fix SACCH interval remapping in test_is_meas_overdue()
......................................................................


Patch Set 1: Code-Review-1

(12 comments)

https://gerrit.osmocom.org/#/c/10760/1/src/common/measurement.c
File src/common/measurement.c:

https://gerrit.osmocom.org/#/c/10760/1/src/common/measurement.c@304
PS1, Line 304: This function MUST only be used
             :  * with TCH/H and TCH/F channels
This way it makes sense to add '_tch' postfix to this symbol.


https://gerrit.osmocom.org/#/c/10760/1/src/common/measurement.c@403
PS1, Line 403: if(modulus == 104)
Coding style?


https://gerrit.osmocom.org/#/c/10760/1/src/common/measurement.c@418
PS1, Line 418: if(modulus == 104)
Same here.


https://gerrit.osmocom.org/#/c/10760/1/src/common/measurement.c@429
PS1, Line 429: if(modulus == 104)
and here...


https://gerrit.osmocom.org/#/c/10760/1/src/common/measurement.c@860
PS1, Line 860: 	return rc;
cosmetic: why not to return exactly from the condition branches?


https://gerrit.osmocom.org/#/c/10760/1/tests/meas/meas_test.c
File tests/meas/meas_test.c:

https://gerrit.osmocom.org/#/c/10760/1/tests/meas/meas_test.c@71
PS1, Line 71: 	lchan_meas_reset(lchan);
Let's keep the original order of function calls.


https://gerrit.osmocom.org/#/c/10760/1/tests/meas/meas_test.c@932
PS1, Line 932: printf
             : 				    (
Coding style? Why do we need to have this wrap?


https://gerrit.osmocom.org/#/c/10760/1/tests/meas/meas_test.c@937
PS1, Line 937: printf
             : 			    (
same here


https://gerrit.osmocom.org/#/c/10760/1/tests/meas/meas_test.c@941
PS1, Line 941: printf
             : 			    (
same here


https://gerrit.osmocom.org/#/c/10760/1/tests/meas/meas_test.c@956
PS1, Line 956: printf
             : 			    (
same here


https://gerrit.osmocom.org/#/c/10760/1/tests/meas/meas_test.c@960
PS1, Line 960: rc +=
             : 			    
and here too...


https://gerrit.osmocom.org/#/c/10760/1/tests/meas/meas_test.c@978
PS1, Line 978: 
ws



-- 
To view, visit https://gerrit.osmocom.org/10760
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf6db73f67b7273c3d5965616c9e78f66b74a406
Gerrit-Change-Number: 10760
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 04 Sep 2018 16:42:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180904/b331e84a/attachment.htm>