This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Keith Whyte gerrit-no-reply at lists.osmocom.orgKeith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/10733 Change subject: Log using GSM48 Cause Value strings ...................................................................... Log using GSM48 Cause Value strings Use gsm48_cc_cause_name() in logging messages Depends-On: I296f208581ce2550805f9d96e20f7319e1199023 Change-Id: I6e3541b66cb3407f0cb23fb6e00a04685fe90757 --- M src/mncc.c M src/sip.c 2 files changed, 9 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/33/10733/1 diff --git a/src/mncc.c b/src/mncc.c index 2de0482..25b6702 100644 --- a/src/mncc.c +++ b/src/mncc.c @@ -25,6 +25,7 @@ #include "call.h" #include <osmocom/gsm/protocol/gsm_03_40.h> +#include <osmocom/gsm/protocol/gsm_04_08.h> #include <osmocom/core/socket.h> #include <osmocom/core/utils.h> @@ -264,7 +265,7 @@ case MNCC_CC_PROCEEDING: case MNCC_CC_CONNECTED: LOGP(DMNCC, LOGL_DEBUG, - "Releasing call in non-initial leg(%u) cause(%d)\n", leg->callref, leg->base.cause); + "Releasing call in non-initial leg(%u) cause(%s)\n", leg->callref, gsm48_cc_cause_name(leg->base.cause)); leg->base.in_release = true; start_cmd_timer(leg, MNCC_REL_IND); mncc_send(leg->conn, MNCC_DISC_REQ, leg->callref); @@ -508,7 +509,7 @@ return; LOGP(DMNCC, - LOGL_DEBUG, "Rcvd MNCC_DISC_IND, Cause: %d\n", data->cause.value); + LOGL_DEBUG, "Rcvd MNCC_DISC_IND, Cause: %s\n", gsm48_cc_cause_name(data->cause.value)); LOGP(DMNCC, LOGL_DEBUG, "leg(%u) was disconnected. Releasing\n", data->callref); leg->base.in_release = true; @@ -530,7 +531,7 @@ if (!leg) return; - LOGP(DMNCC, LOGL_DEBUG, "Rcvd MNCC_REL_IND, Cause: %d\n", data->cause.value); + LOGP(DMNCC, LOGL_DEBUG, "Rcvd MNCC_REL_IND, Cause: %s\n", gsm48_cc_cause_name(data->cause.value)); if (leg->base.in_release) stop_cmd_timer(leg, MNCC_REL_IND); @@ -588,7 +589,7 @@ if (other_leg) other_leg->cause = data->cause.value; other_leg->release_call(other_leg); - LOGP(DMNCC, LOGL_DEBUG, "leg(%u) was rejected with cause(%d).\n", data->callref, leg->cause); + LOGP(DMNCC, LOGL_DEBUG, "leg(%u) was rejected with cause(%s).\n", data->callref, gsm48_cc_cause_name(leg->cause)); mncc_leg_release(leg); } diff --git a/src/sip.c b/src/sip.c index cf457ad..adf20d8 100644 --- a/src/sip.c +++ b/src/sip.c @@ -298,12 +298,12 @@ *sip_status = cause_map[i].sip_status; *sip_phrase = cause_map[i].sip_phrase; *reason_text = cause_map[i].q850_reason; - LOGP(DSIP, LOGL_DEBUG, "%s(): Mapping cause(%d) to status(%d)\n", - __func__, cause, *sip_status); + LOGP(DSIP, LOGL_DEBUG, "%s(): Mapping cause(%s) to status(%d)\n", + __func__, gsm48_cc_cause_name(cause), *sip_status); return; } } - LOGP(DSIP, LOGL_ERROR, "%s(): Cause(%d) not found in map.\n", __func__, cause); + LOGP(DSIP, LOGL_ERROR, "%s(): Cause(%s) not found in map.\n", __func__, gsm48_cc_cause_name(cause)); *sip_status = cause_map[i].sip_status; *sip_phrase = cause_map[i].sip_phrase; *reason_text = cause_map[i].q850_reason; @@ -327,7 +327,7 @@ * to help us here. */ - LOGP(DSIP, LOGL_DEBUG, "%s(): Release with MNCC cause(%d)\n", __func__, _leg->cause); + LOGP(DSIP, LOGL_DEBUG, "%s(): Release with MNCC cause(%s)\n", __func__, gsm48_cc_cause_name(_leg->cause)); cause2status(_leg->cause, &sip_cause, &sip_phrase, &reason_text); snprintf(reason, sizeof reason, "Q.850;cause=%u;text=\"%s\"", _leg->cause, reason_text); -- To view, visit https://gerrit.osmocom.org/10733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6e3541b66cb3407f0cb23fb6e00a04685fe90757 Gerrit-Change-Number: 10733 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <keith at rhizomatica.org> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180901/445d30cd/attachment.htm>