This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgHolger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/11516 ) Change subject: Integrate mass LU test to run fine under osmo-gsm-tester ...................................................................... Patch Set 2: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/11516/2/src/osmo_ms_driver/starter.py File src/osmo_ms_driver/starter.py: https://gerrit.osmocom.org/#/c/11516/2/src/osmo_ms_driver/starter.py@64 PS2, Line 64: #pcap_recorder.PcapRecorder(self.suite_run, self.run_dir.new_dir('pcap'), None, : # 'host %s and port not 22' % self.addr()) I think starting 10k tcpdump is not that desirable. https://gerrit.osmocom.org/#/c/11516/2/src/osmo_ms_driver/starter.py@55 PS2, Line 55: inst = util.Dir(os.path.abspath(self.suite_run.trial.get_inst('osmocom-bb'))) : : binary = inst.child('bin', 'virtphy') : if not os.path.isfile(binary): : raise RuntimeError('Binary missing: %r' % binary) : lib = inst.child('lib') : if not os.path.isdir(lib): : raise RuntimeError('No lib/ in %r' % inst) : : #pcap_recorder.PcapRecorder(self.suite_run, self.run_dir.new_dir('pcap'), None, : # 'host %s and port not 22' % self.addr()) : : env = { 'LD_LIBRARY_PATH': util.prepend_library_path(lib) } Can this be in a helper returning the binary + env? https://gerrit.osmocom.org/#/c/11516/2/src/osmo_ms_driver/starter.py@141 PS2, Line 141: self.run_dir = util.Dir(self.suite_run.get_test_run_dir().new_dir(self.name())) : : inst = util.Dir(os.path.abspath(self.suite_run.trial.get_inst('osmocom-bb'))) : : binary = inst.child('bin', 'mobile') : if not os.path.isfile(binary): : raise RuntimeError('Binary missing: %r' % binary) : lib = inst.child('lib') : if not os.path.isdir(lib): : raise RuntimeError('No lib/ in %r' % inst) : : #pcap_recorder.PcapRecorder(self.suite_run, self.run_dir.new_dir('pcap'), None, : # 'host %s and port not 22' % self.addr()) : : env = { 'LD_LIBRARY_PATH': util.prepend_library_path(lib) } Utility function please. -- To view, visit https://gerrit.osmocom.org/11516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6748fce6ca25c7d4daedafe87b6b77c471d17bf9 Gerrit-Change-Number: 11516 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 30 Oct 2018 21:22:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181030/fe73c768/attachment.htm>