This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11246 ) Change subject: layer23/common: introduce L23SAP API for L1CTL ...................................................................... Patch Set 2: > I don't really understand what we gain from this. Sure, I can read > your statement and agree that it removes the need to have lapdm.h > included and used. But why is that a problem? > Whar are you trying to fix here? Removing 'lapdm*.h' is not the main idea of this change. The main idea is to make the code a bit more modular and cleaner. Here is a little example: Let's say I am a new developer, and I need to understand how the patch loss criteria is implemented. Where should I look? It's quite odd that I would find it in the L1CTL handling implementation. How is it related to L1CTL?!? Moreover, changing / fixing the logic of the mentioned parts (unrelated to L1CTL itself) would look like changing the L1CTL logic in the git history, because everything is mixed in a single file. -- To view, visit https://gerrit.osmocom.org/11246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22d7932ddc03c692f2616726ced53b6e8eef822d Gerrit-Change-Number: 11246 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Mon, 29 Oct 2018 23:53:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181029/ba2a4bd3/attachment.htm>