This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11494 ) Change subject: show RTP TX/RX stats in 'mgcp show stats' output ...................................................................... show RTP TX/RX stats in 'mgcp show stats' output Make the 'mgcp show stats' VTY command display TX/RX counters for an RTP stream. This command was already showing the counter for dropped packets from the same counter group, so it seems natural to display other relevant counters in the group as well. Change-Id: I1313e64d7d8b49964f21fc8d213cba6c9fb6c7cf Related: OS#2660 --- M src/libosmo-mgcp/mgcp_vty.c 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c index fdcca91..5643180 100644 --- a/src/libosmo-mgcp/mgcp_vty.c +++ b/src/libosmo-mgcp/mgcp_vty.c @@ -162,11 +162,19 @@ struct mgcp_rtp_state *state = &conn->state; struct mgcp_rtp_end *end = &conn->end; struct mgcp_rtp_codec *codec = end->codec; + struct rate_ctr *tx_packets, *tx_bytes; + struct rate_ctr *rx_packets, *rx_bytes; struct rate_ctr *dropped_packets; + tx_packets = &conn->rate_ctr_group->ctr[RTP_PACKETS_TX_CTR]; + tx_bytes = &conn->rate_ctr_group->ctr[RTP_OCTETS_TX_CTR]; + rx_packets = &conn->rate_ctr_group->ctr[RTP_PACKETS_RX_CTR]; + rx_bytes = &conn->rate_ctr_group->ctr[RTP_OCTETS_RX_CTR]; dropped_packets = &conn->rate_ctr_group->ctr[RTP_DROPPED_PACKETS_CTR]; vty_out(vty, + " Packets Sent: %" PRIu64 " (%" PRIu64 " bytes total)%s" + " Packets Received: %" PRIu64 " (%" PRIu64 " bytes total)%s" " Timestamp Errs: %" PRIu64 "->%" PRIu64 "%s" " Dropped Packets: %" PRIu64 "%s" " Payload Type: %d Rate: %u Channels: %d %s" @@ -174,6 +182,8 @@ " FPP: %d Packet Duration: %u%s" " FMTP-Extra: %s Audio-Name: %s Sub-Type: %s%s" " Output-Enabled: %d Force-PTIME: %d%s", + tx_packets->current, tx_bytes->current, VTY_NEWLINE, + rx_packets->current, rx_bytes->current, VTY_NEWLINE, state->in_stream.err_ts_ctr->current, state->out_stream.err_ts_ctr->current, VTY_NEWLINE, -- To view, visit https://gerrit.osmocom.org/11494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1313e64d7d8b49964f21fc8d213cba6c9fb6c7cf Gerrit-Change-Number: 11494 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181029/4d1d3908/attachment.htm>