This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgStefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11496 Change subject: add more mgcp crxc error counters ...................................................................... add more mgcp crxc error counters Add counters for error conditions which I overlooked in commit 1e174875bf72c3d7840fa98cfad8c410a542919e Change-Id: Ia2004f8063f3a50b5d7a838ebe8a784a47fcc50d Depends: If4f097c5e441914eaa24c7657813ebb3f9a49916 Related: OS#2660 --- M include/osmocom/mgcp/mgcp.h M src/libosmo-mgcp/mgcp_protocol.c 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/96/11496/1 diff --git a/include/osmocom/mgcp/mgcp.h b/include/osmocom/mgcp/mgcp.h index f9f0ac7..b866f91 100644 --- a/include/osmocom/mgcp/mgcp.h +++ b/include/osmocom/mgcp/mgcp.h @@ -131,6 +131,10 @@ MGCP_CRCX_FAIL_NO_REMOTE_CONN_DESC, MGCP_CRCX_FAIL_START_RTP, MGCP_CRCX_FAIL_REJECTED_BY_POLICY, + MGCP_CRCX_FAIL_NO_OSMUX, + MGCP_CRCX_FAIL_INVALID_CONN_OPTIONS, + MGCP_CRCX_FAIL_CODEC_NEGOTIATION, + MGCP_CRCX_FAIL_BIND_PORT, }; struct mgcp_trunk_config { diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 24c8e54..ccbdfc8 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -64,6 +64,10 @@ [MGCP_CRCX_FAIL_NO_REMOTE_CONN_DESC] = {"crcx:no_remote_conn_desc", "no opposite end specified for connection."}, [MGCP_CRCX_FAIL_START_RTP] = {"crcx:start_rtp_failure", "failure to start RTP processing."}, [MGCP_CRCX_FAIL_REJECTED_BY_POLICY] = {"crcx:conn_rejected", "connection rejected by policy."}, + [MGCP_CRCX_FAIL_NO_OSMUX] = {"crcx:no_osmux", "no osmux offered by peer."}, + [MGCP_CRCX_FAIL_INVALID_CONN_OPTIONS] = {"crcx:conn_opt", "connection options invalid."}, + [MGCP_CRCX_FAIL_CODEC_NEGOTIATION] = {"crcx:codec_nego", "codec negotiation failure."}, + [MGCP_CRCX_FAIL_BIND_PORT] = {"crcx:bind_port", "port bind failure."}, }; const static struct rate_ctr_group_desc mgcp_crcx_ctr_group_desc = { @@ -863,6 +867,7 @@ if (mgcp_parse_conn_mode(mode, endp, conn->conn) != 0) { error_code = 517; + rate_ctr_inc(&rate_ctrs->ctr[MGCP_CRCX_FAIL_INVALID_MODE]); goto error2; } @@ -876,6 +881,7 @@ LOGP(DLMGCP, LOGL_ERROR, "CRCX: endpoint:0x%x osmux only and no osmux offered\n", ENDPOINT_NUMBER(endp)); + rate_ctr_inc(&rate_ctrs->ctr[MGCP_CRCX_FAIL_NO_OSMUX]); goto error2; } @@ -888,6 +894,7 @@ "CRCX: endpoint:%x inavlid local connection options!\n", ENDPOINT_NUMBER(endp)); error_code = rc; + rate_ctr_inc(&rate_ctrs->ctr[MGCP_CRCX_FAIL_INVALID_CONN_OPTIONS]); goto error2; } } @@ -897,6 +904,7 @@ mgcp_codec_summary(conn); if (rc) { error_code = rc; + rate_ctr_inc(&rate_ctrs->ctr[MGCP_CRCX_FAIL_CODEC_NEGOTIATION]); goto error2; } @@ -923,6 +931,7 @@ } if (allocate_port(endp, conn) != 0) { + rate_ctr_inc(&rate_ctrs->ctr[MGCP_CRCX_FAIL_BIND_PORT]); goto error2; } -- To view, visit https://gerrit.osmocom.org/11496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2004f8063f3a50b5d7a838ebe8a784a47fcc50d Gerrit-Change-Number: 11496 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181029/23541f14/attachment.htm>