Change in osmo-mgw[master]: mgcp_protocol: increase buffer space for codec name in LCO

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Oct 26 12:55:34 UTC 2018


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11466


Change subject: mgcp_protocol: increase buffer space for codec name in LCO
......................................................................

mgcp_protocol: increase buffer space for codec name in LCO

The function that parses the LCO uses an internal buffer to store the
codec name that has been issued via LCO. This buffer is only 9 byte
long, this means an 8 character string can be stored. If a codec name
exceeds this limit it gets chopped. For example "GSM-HR-08" becomes
"GSM-HR-0", which may mess up the codec negotiation.

- Increase the buffer from 9 to 17 byte.

Change-Id: I17ce7acde1f23ab1394227d74214fe2a55cd2264
Related: OS#3673
---
M src/libosmo-mgcp/mgcp_protocol.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/66/11466/1

diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index e17bdae..860692f 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -518,7 +518,7 @@
 				 const char *options)
 {
 	char *p_opt, *a_opt;
-	char codec[9];
+	char codec[17];
 
 	if (!options)
 		return 0;
@@ -544,7 +544,7 @@
 	 * (e.g. a:PCMU;G726-32) But this implementation only supports a single
 	 * codec only. */
 	a_opt = strstr(lco->string, "a:");
-	if (a_opt && sscanf(a_opt, "a:%8[^,]", codec) == 1) {
+	if (a_opt && sscanf(a_opt, "a:%16[^,]", codec) == 1) {
 		talloc_free(lco->codec);
 		lco->codec = talloc_strdup(ctx, codec);
 	}

-- 
To view, visit https://gerrit.osmocom.org/11466
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17ce7acde1f23ab1394227d74214fe2a55cd2264
Gerrit-Change-Number: 11466
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181026/5495e9fe/attachment.htm>


More information about the gerrit-log mailing list