Change in osmo-bts[master]: Add OC-2G to build

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11449 )

Change subject: Add OC-2G to build
......................................................................


Patch Set 1:

(2 comments)

I think the three patches in this series should be merged into one patch.  The retionale is: Only if the build infrastructure is added together with the soruce code, we can do build verification as part of patch verification (V+1) and a subsequent merge.

https://gerrit.osmocom.org/#/c/11449/1/include/osmo-bts/gsm_data_shared.h
File include/osmo-bts/gsm_data_shared.h:

https://gerrit.osmocom.org/#/c/11449/1/include/osmo-bts/gsm_data_shared.h@414
PS1, Line 414: uint8_t max_power_backoff_8psk; /* in actual dB */
             :         uint8_t c0_idle_power_red;      /* in actual dB */
would be good to mark those as "OC2G only for now" in the comment


https://gerrit.osmocom.org/#/c/11449/1/include/osmo-bts/l1sap.h
File include/osmo-bts/l1sap.h:

https://gerrit.osmocom.org/#/c/11449/1/include/osmo-bts/l1sap.h@53
PS1, Line 53: 		return L1SAP_CHAN2SS_BCCH(chan_nr);
unrelated cosmetic change, lets' try to avoid that.



-- 
To view, visit https://gerrit.osmocom.org/11449
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a8dcf759a2818c8e457bcb82775c4e60c94d771
Gerrit-Change-Number: 11449
Gerrit-PatchSet: 1
Gerrit-Owner: Omar Ramadan <omar.ramadan93 at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 26 Oct 2018 10:45:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181026/ca6f373c/attachment.htm>