Change in libosmocore[master]: stats_statsd: Send all stat_items as gauges

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Wed Oct 24 21:25:11 UTC 2018


Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/11323 )

Change subject: stats_statsd: Send all stat_items as gauges
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11323/2/src/stats_statsd.c
File src/stats_statsd.c:

https://gerrit.osmocom.org/#/c/11323/2/src/stats_statsd.c@196
PS2, Line 196: value
What is the difference between the two branches? value vs. 0? Could you use max(value, 0) then and simplify it further?



-- 
To view, visit https://gerrit.osmocom.org/11323
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia16270d36c9a14521594de4b99a48c83e4ac07d4
Gerrit-Change-Number: 11323
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Wed, 24 Oct 2018 21:25:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181024/b8970b21/attachment.htm>


More information about the gerrit-log mailing list