Change in libosmocore[master]: stats_statsd: Send all stat_items as gauges

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11323 )

Change subject: stats_statsd: Send all stat_items as gauges
......................................................................

stats_statsd: Send all stat_items as gauges

When sending a statsd metric we need to specify a type which can be a
"g"auge, "c"ounter, "t"imer, "h"istogram, and "m"eter.

We used to just pass the stat_item unit into this field, but that is the
unit of the metric (Seconds for a timer, % for utilization, ...).

Change the type field so stat_items are sent as "g"auges. Note that
negative values don't seem to be supported by statsd.

Change-Id: Ia16270d36c9a14521594de4b99a48c83e4ac07d4
---
M src/stats_statsd.c
1 file changed, 8 insertions(+), 11 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/stats_statsd.c b/src/stats_statsd.c
index 5ae2570..c3f739e 100644
--- a/src/stats_statsd.c
+++ b/src/stats_statsd.c
@@ -184,20 +184,17 @@
 	const struct osmo_stat_item_group *statg,
 	const struct osmo_stat_item_desc *desc, int64_t value)
 {
-	const char *unit = desc->unit;
-
-	if (unit == OSMO_STAT_ITEM_NO_UNIT) {
-		unit = "g";
-		if (value < 0)
-			osmo_stats_reporter_statsd_send(srep,
+	if (value < 0) {
+		return osmo_stats_reporter_statsd_send(srep,
 				statg->desc->group_name_prefix,
 				statg->idx,
-				desc->name, 0, unit);
+				desc->name, 0, "g");
+	} else {
+		return osmo_stats_reporter_statsd_send(srep,
+			statg->desc->group_name_prefix,
+			statg->idx,
+			desc->name, value, "g");
 	}
-	return osmo_stats_reporter_statsd_send(srep,
-		statg->desc->group_name_prefix,
-		statg->idx,
-		desc->name, value, unit);
 }
 #endif /* !EMBEDDED */
 

-- 
To view, visit https://gerrit.osmocom.org/11323
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia16270d36c9a14521594de4b99a48c83e4ac07d4
Gerrit-Change-Number: 11323
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181024/a5bb114d/attachment.htm>