Change in osmo-ttcn3-hacks[master]: RSL_Emulation: Fail explicitly on ASP_IPA_EVENT_DOWN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Wed Oct 24 11:02:39 UTC 2018


daniel has posted comments on this change. ( https://gerrit.osmocom.org/11429 )

Change subject: RSL_Emulation: Fail explicitly on ASP_IPA_EVENT_DOWN
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/11429/3/library/RSL_Emulation.ttcn
File library/RSL_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/11429/3/library/RSL_Emulation.ttcn@357
PS3, Line 357: 			// Both doesn't really make sense
Pau, I'm not sure what to do here. Since we failed before anyway it probably makes sense to fail as well.

Just thinking about it, it's probably best to not have a guard expression and just have one alt statement for IPA_EVENT_DOWN. Does that make sense?



-- 
To view, visit https://gerrit.osmocom.org/11429
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc6565c9de72d98015d56a41e5616c46051c8a8d
Gerrit-Change-Number: 11429
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 24 Oct 2018 11:02:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181024/592ec88c/attachment.htm>


More information about the gerrit-log mailing list