Change in osmo-ttcn3-hacks[master]: RSL_Emulation: handle ASP_IPA_EVENT_DOWN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Tue Oct 23 17:29:47 UTC 2018


daniel has posted comments on this change. ( https://gerrit.osmocom.org/11429 )

Change subject: RSL_Emulation: handle ASP_IPA_EVENT_DOWN
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG@9
PS2, Line 9: Otherwise RSL layer fails this way when this event is received:
> Why are we expecting the RSL layer to ever receive an ASP_IPA_EVENT_DOWN?  I agree the message is a  […]
I spoke with pespin and we basically concluded, that this seems to be another issue due to high load. The BTS 
did not receive the clock from osmo-trx (or what's driving osmo-bts in the test).

‎[19:21:15] ‎pespin‎: Wed Oct 17 07:22:32 2018 DOML <0001> bts.c:239 Shutting down BTS 0, Reason No clock from osmo-trx

So failing explicitly in these cases seems the better idea.

For an explicit failure you should call "all component.stop" after the setverdict(fail) so that we don't run into any dynamic testcase errors due to unconnected ports that get messages.
‎
BTS_Tests has an f_shutdown function which does that exactly and should probably be moved to a common place since this should just be callable from about anywhere.



-- 
To view, visit https://gerrit.osmocom.org/11429
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc6565c9de72d98015d56a41e5616c46051c8a8d
Gerrit-Change-Number: 11429
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 23 Oct 2018 17:29:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181023/cba54093/attachment.htm>


More information about the gerrit-log mailing list