Change in osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix: don't overwrite the expected meas results

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Oct 21 12:29:50 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11228 )

Change subject: BTS_Tests.ttcn: fix: don't overwrite the expected meas results
......................................................................

BTS_Tests.ttcn: fix: don't overwrite the expected meas results

Since OS#2988 was fixed, we should not overwrite nor ignore the
measurement results in f_build_meas_res_tmpl().

Change-Id: Ie902bfc7619181b528eafbce367c87e0b062243a
---
M bts/BTS_Tests.ttcn
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index e0470ec..2f48b0f 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1273,11 +1273,6 @@
 			toa256_std_dev := ?
 		}
 	}
-	/* HACK HACK HACK FIXME HACK HACK HACK see https://osmocom.org/issues/2988 */
-	ul_meas.rxlev_f_u := ?;
-	ul_meas.rxlev_s_u := ?;
-	ul_meas.rxq_f_u := ?;
-	ul_meas.rxq_s_u := ?;
 	var template RSL_IE_BS_Power bs_power := {
 		reserved := 0,
 		epc := false,

-- 
To view, visit https://gerrit.osmocom.org/11228
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie902bfc7619181b528eafbce367c87e0b062243a
Gerrit-Change-Number: 11228
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Assignee: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181021/6bb2b200/attachment.htm>


More information about the gerrit-log mailing list