Change in osmo-iuh[master]: hnbgw_tx_hnb_register_rej(): Missing return statement

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Oct 21 11:41:30 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11400 )

Change subject: hnbgw_tx_hnb_register_rej(): Missing return statement
......................................................................

hnbgw_tx_hnb_register_rej(): Missing return statement

Change-Id: I0bdee8ede9ffdc16c16a4f5723acb7b4bceb2158
Fixes: Coverity CID#188869
---
M src/hnbgw_hnbap.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/hnbgw_hnbap.c b/src/hnbgw_hnbap.c
index 2a19dda..1d50d4d 100644
--- a/src/hnbgw_hnbap.c
+++ b/src/hnbgw_hnbap.c
@@ -85,7 +85,10 @@
 	} else {
 		/* The message was not queued. Destroy the connection right away. */
 		hnb_context_release(ctx);
+		return rc;
 	}
+
+	return 0;
 }
 
 static int hnbgw_tx_hnb_register_acc(struct hnb_context *ctx)

-- 
To view, visit https://gerrit.osmocom.org/11400
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bdee8ede9ffdc16c16a4f5723acb7b4bceb2158
Gerrit-Change-Number: 11400
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181021/ce23ed6a/attachment.htm>


More information about the gerrit-log mailing list