This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/11325 ) Change subject: libosmogsm/gsup.c: assert message type in osmo_gsup_encode() ...................................................................... Patch Set 1: Code-Review-1 Have you found some way to trigger this? In general I'd rather let the caller handle this instead of forcing segfault upon it: those are hard to debug and next to impossible to test beforehand. How would you justify potential fallout in the projects using it? -- To view, visit https://gerrit.osmocom.org/11325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbac18e2b68b765c17c2bc959c4c085037953a7f Gerrit-Change-Number: 11325 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Comment-Date: Sat, 20 Oct 2018 12:04:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181020/905040bf/attachment.htm>