Change in osmo-msc[master]: gsm_04_08_cc: Add global guard timer for MNCC

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11307 )

Change subject: gsm_04_08_cc: Add global guard timer for MNCC
......................................................................


Patch Set 3: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/11307/3/src/libmsc/gsm_04_08_cc.c
File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/#/c/11307/3/src/libmsc/gsm_04_08_cc.c@80
PS3, Line 80: 	       vlr_subscr_msisdn_or_name(trans->vsub));
(best use same formatting as other logging in this file, e.g. line 2025)


https://gerrit.osmocom.org/#/c/11307/3/src/libmsc/gsm_04_08_cc.c@89
PS3, Line 89: 		       vlr_subscr_msisdn_or_name(trans->vsub));
re


https://gerrit.osmocom.org/#/c/11307/3/src/libmsc/osmo_msc.c
File src/libmsc/osmo_msc.c:

https://gerrit.osmocom.org/#/c/11307/3/src/libmsc/osmo_msc.c@57
PS3, Line 57: 	/* If the mncc interface remains silent for more then 3 minutes,
("than" .. "during setup" ... or maybe just drop the comment anyway, it's obvious enough)



-- 
To view, visit https://gerrit.osmocom.org/11307
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7375d1e17cd746aac4eadfe1e587e82cf1630d3d
Gerrit-Change-Number: 11307
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Oct 2018 14:10:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181017/2f17e270/attachment.htm>