Change in osmo-bsc[master]: gsm_08_08: do not include zero length speech codec list.

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/11388 )

Change subject: gsm_08_08: do not include zero length speech codec list.
......................................................................


Patch Set 1:

> I am not sure we want to merge this patch. Why do you think having
 > no speech codec elements in list means "user plane interface is not
 > supported"? It can still support it but be misconfigured or on
 > purpose configured to have no codecs available?

(From my understanding the ip based user plane interface refers to RTP voice.)

I think its a matter of interpretation. The spec says that the element shall be
included if supported. So in revers this means if its missing, the ip based user
plane is not supported.

This is surely debatable. From my personal taste I think a speech codec list with
zero elements makes it easier to spot that something is wrong.


-- 
To view, visit https://gerrit.osmocom.org/11388
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07339322a71376e986a2d75b7bc1f552eafd02b5
Gerrit-Change-Number: 11388
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Oct 2018 07:50:24 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181017/884c06ca/attachment.htm>