Change in openbsc[master]: mgcp: osmux_send_dummy: Fix return without value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Oct 16 20:41:49 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11372 )

Change subject: mgcp: osmux_send_dummy: Fix return without value
......................................................................

mgcp: osmux_send_dummy: Fix return without value

Not really critical since only user of this function doesn't check the
return value.

Fixes commit: 4a2cc9eb0a0f9424c16b26fcb757483a39d67482
Change-Id: I438349bffaa46a10ad8983090a4b17aed7e00d82
---
M openbsc/src/libmgcp/mgcp_osmux.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libmgcp/mgcp_osmux.c b/openbsc/src/libmgcp/mgcp_osmux.c
index a0ac295..ce344ca 100644
--- a/openbsc/src/libmgcp/mgcp_osmux.c
+++ b/openbsc/src/libmgcp/mgcp_osmux.c
@@ -554,7 +554,7 @@
 		return 0;
 
 	if (endp_osmux_state_check(endp, &endp->net_end.addr, true) < 0)
-		return;
+		return 0;
 
 	LOGP(DMGCP, LOGL_DEBUG,
 	     "sending OSMUX dummy load to %s CID %u\n",

-- 
To view, visit https://gerrit.osmocom.org/11372
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I438349bffaa46a10ad8983090a4b17aed7e00d82
Gerrit-Change-Number: 11372
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181016/d3d8344c/attachment.htm>


More information about the gerrit-log mailing list