Change in docker-playground[master]: jenkins.sh: IMAGE_SUFFIX, docker_images_require()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Oct 16 13:06:13 UTC 2018


osmith has posted comments on this change. ( https://gerrit.osmocom.org/11366 )

Change subject: jenkins.sh: IMAGE_SUFFIX, docker_images_require()
......................................................................


Patch Set 2:

(3 comments)

> As you will notice in the comments, it's not so easy for me to let go of my current use pattern of 'make ttcn3-bsc-test' once, then invoke jenkins.sh as many times I like

We discusses this in the chat after you wrote this, and you said it's okay for you to use one of the following instead of your current make-then-call-jenkins.sh-workflow.

  $ ./jenkins.sh 
  $ NO_DOCKER_IMAGE_BUILD=1 ./jenkins.sh

https://gerrit.osmocom.org/#/c/11366/1/m3ua-test/jenkins.sh
File m3ua-test/jenkins.sh:

https://gerrit.osmocom.org/#/c/11366/1/m3ua-test/jenkins.sh@4
PS1, Line 4: IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}"
> I still prefer […]
Done


https://gerrit.osmocom.org/#/c/11366/1/m3ua-test/jenkins.sh@6
PS1, Line 6: 	"debian-jessie-build" \
> so it is not enough to issue the osmo-stp-foo image below, to also rebuild the images that it depend […]
I thought about resolving these dependencies in jenkins-common.sh, but that would add a lot more code than the two additional lines (debian-jessie-build, debian-stretch-titan) in these jenkins.sh files. So having it here is probably the nicer solution, although it is a bit redundant.


https://gerrit.osmocom.org/#/c/11366/1/m3ua-test/jenkins.sh@7
PS1, Line 7: 	"osmo-stp-$IMAGE_SUFFIX" \
> with IMAGE_SUFFIX, I think of ".img". […]
There's already a FEED variable in docker-playground.git/debian-repo-install-test/jenkins.sh, which takes different values ("nightly" and "latest"). Here "master" and "latest" is accepted, so it might get confusing.

However, if you still prefer FEED_NAME (or have another suggestion), I can change it of course.



-- 
To view, visit https://gerrit.osmocom.org/11366
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbb708ab16cb71bab5069127945b63388222369e
Gerrit-Change-Number: 11366
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Oct 2018 13:06:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181016/a6cb0ecf/attachment.htm>


More information about the gerrit-log mailing list