Change in osmo-remsim[master]: rspro_gen_ConnectClientReq(): don't dereference optional 'client'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Oct 15 00:27:21 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11350 )

Change subject: rspro_gen_ConnectClientReq(): don't dereference optional 'client'
......................................................................

rspro_gen_ConnectClientReq(): don't dereference optional 'client'

Change-Id: Id5ff7f1524bc34576095d6812935557c7f03b545
---
M src/rspro_util.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/rspro_util.c b/src/rspro_util.c
index 95e8cfc..0452728 100644
--- a/src/rspro_util.c
+++ b/src/rspro_util.c
@@ -118,7 +118,8 @@
 		return NULL;
 	pdu->msg.present = RsproPDUchoice_PR_connectClientReq;
 	fill_comp_id(&pdu->msg.choice.connectClientReq.identity, a_cid);
-	ASN_ALLOC_COPY(pdu->msg.choice.connectClientReq.clientSlot, client);
+	if (client)
+		ASN_ALLOC_COPY(pdu->msg.choice.connectClientReq.clientSlot, client);
 
 	return pdu;
 }

-- 
To view, visit https://gerrit.osmocom.org/11350
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5ff7f1524bc34576095d6812935557c7f03b545
Gerrit-Change-Number: 11350
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181015/e963627e/attachment.htm>


More information about the gerrit-log mailing list