Change in osmo-dev[master]: find the terminal once and abort if missing

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11143 )

Change subject: find the terminal once and abort if missing
......................................................................


Patch Set 6: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/#/c/11143/6/net/tmpl_std/run.sh
File net/tmpl_std/run.sh:

https://gerrit.osmocom.org/#/c/11143/6/net/tmpl_std/run.sh@37
PS6, Line 37: find_term() {
(I'd have just put it on the root level scope, but fine if you think a function looks better...)


https://gerrit.osmocom.org/#/c/11143/6/net/tmpl_std/run.sh@43
PS6, Line 43:     [ -n "$terminal" ] && return
I find the expanded 'if' clauses easier to read, especially for people not that familiar with shell scripting.

Anyway. next time is fine.



-- 
To view, visit https://gerrit.osmocom.org/11143
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie823e17ff1e7ad3ba23998233b41a810c90858b3
Gerrit-Change-Number: 11143
Gerrit-PatchSet: 6
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Oct 2018 10:51:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181012/7b1e6719/attachment.htm>