Change in osmo-bsc[master]: handover_decision_2.c: tweak comments

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11316 )

Change subject: handover_decision_2.c: tweak comments
......................................................................

handover_decision_2.c: tweak comments

Change-Id: I8bae3431dfaf23301e72f8f572286753b63a99b9
---
M src/osmo-bsc/handover_decision_2.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c
index 4e9b02c..70be050 100644
--- a/src/osmo-bsc/handover_decision_2.c
+++ b/src/osmo-bsc/handover_decision_2.c
@@ -471,6 +471,7 @@
 		break;
 	default:
 		LOGPHOLCHANTOBTS(lchan, bts, LOGL_DEBUG, "Not even considering: src is not a SPEECH mode lchan\n");
+		/* FIXME: should allow handover of non-speech lchans */
 		return 0;
 	}
 
@@ -556,7 +557,7 @@
 	}
 #endif
 
-	/* the maximum number of unsynchonized handovers must no be exceeded */
+	/* the maximum number of unsynchronized handovers must no be exceeded */
 	if (current_bts != bts
 	    && bts_handover_count(bts, HO_SCOPE_ALL) >= ho_get_hodec2_ho_max(bts->ho)) {
 		LOGPHOLCHANTOBTS(lchan, bts, LOGL_DEBUG,
@@ -679,7 +680,7 @@
 	return 0;
 }
 
-/* debug collected candidates */
+/* verbosely log about a handover candidate */
 static inline void debug_candidate(struct gsm_lchan *lchan, struct ho_candidate *candidate,
 	struct gsm_bts *neighbor, int8_t rxlev, int tchf_count, int tchh_count)
 {

-- 
To view, visit https://gerrit.osmocom.org/11316
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bae3431dfaf23301e72f8f572286753b63a99b9
Gerrit-Change-Number: 11316
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181012/b7a3a4fd/attachment.htm>