Change in libosmo-abis[master]: ipaccess: add e1inp_sign_link_name()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Oct 11 12:55:15 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11294 )

Change subject: ipaccess: add e1inp_sign_link_name()
......................................................................


Patch Set 1: Code-Review-2

(1 comment)

https://gerrit.osmocom.org/#/c/11294/1/src/e1_input.c
File src/e1_input.c:

https://gerrit.osmocom.org/#/c/11294/1/src/e1_input.c@554
PS1, Line 554: 		return osmo_sock_get_name(NULL, link->ts->driver.ipaccess.fd.fd);
we don't ever want to allocate under a NULL ctx.

After the comment to the other patch, we might as well drop this entire patch..?

Instead of a wrapper like this, I'd suggest to introduce osmo_sock_get_name2() with better API:

* use static buffer
* don't return '()' braces around the string, leave that up to the caller

but I guess we don't need it?



-- 
To view, visit https://gerrit.osmocom.org/11294
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e78ee4dc5c9bd10592c090b9a3b35baf61a6d69
Gerrit-Change-Number: 11294
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Oct 2018 12:55:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181011/dad2ef4b/attachment.htm>


More information about the gerrit-log mailing list