Change in osmo-hlr[master]: fix and re-enable osmo_hlr_subscriber_update_notify()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Oct 11 12:09:20 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11233 )

Change subject: fix and re-enable osmo_hlr_subscriber_update_notify()
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/11233/4/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/11233/4/src/hlr.c@71
PS4, Line 71: 	     osmo_quote_str(subscr->sgsn_number, -1));
actually, tow osmo_quote_str() on the same log won't work. Introducing another name buffer just to log this doesn't seem worth it, particularly since the loop logs each one again. dropping.



-- 
To view, visit https://gerrit.osmocom.org/11233
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c317de8329d9a115d072fc61ddb9abc21b7e8d8
Gerrit-Change-Number: 11233
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Oct 2018 12:09:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181011/e01360da/attachment.htm>


More information about the gerrit-log mailing list