Change in osmo-pcap[master]: Use enum for PKT_LINK_*

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11277 )

Change subject: Use enum for PKT_LINK_*
......................................................................

Use enum for PKT_LINK_*

Makes it easier to understand different types and how they relate to
same field.

Change-Id: I1bec4d5d132a1476f9c418502ad808b7c778cee2
---
M include/osmo-pcap/wireformat.h
1 file changed, 4 insertions(+), 9 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmo-pcap/wireformat.h b/include/osmo-pcap/wireformat.h
index 3f92ee8..54dce22 100644
--- a/include/osmo-pcap/wireformat.h
+++ b/include/osmo-pcap/wireformat.h
@@ -26,15 +26,10 @@
 #include <inttypes.h>
 #include <pcap.h>
 
-/*
- * Should send an entire pcap header
- */
-#define PKT_LINK_HDR	0
-
-/*
- * Should send one packet...
- */
-#define PKT_LINK_DATA	1
+enum OsmoPcapDataType {
+	PKT_LINK_HDR, /* Should send an entire pcap header */
+	PKT_LINK_DATA /* Should send one packet */
+};
 
 struct osmo_pcap_data {
 	uint8_t type;

-- 
To view, visit https://gerrit.osmocom.org/11277
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bec4d5d132a1476f9c418502ad808b7c778cee2
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181008/309c21af/attachment.htm>