This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11258 ) Change subject: common/pcu_sock.c: cosmetic: explicitly address lchan ...................................................................... common/pcu_sock.c: cosmetic: explicitly address lchan In the most cases a PDCH time-slot has only one logical channel allocated. In case of both osmo-bts-trx and osmo-bts-virtual, there are two kinds of logical channels: PDTCH and PTCCH, but since they share the same chan_nr value, deactivating one of them would trigger deactivation of another one. Let's explicitly address the first logical channel in array. Change-Id: I8edcb46e887c4db63a425eba89cec4374165763e Closes: OS#3023 --- M src/common/pcu_sock.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 7f32f32..60e0f7a 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -738,9 +738,9 @@ ts = &trx->ts[j]; if (ts->mo.nm_state.operational == NM_OPSTATE_ENABLED && ts->pchan == GSM_PCHAN_PDCH) { - ts->lchan->rel_act_kind = LCHAN_REL_ACT_PCU; + ts->lchan[0].rel_act_kind = LCHAN_REL_ACT_PCU; l1sap_chan_rel(trx, - gsm_lchan2chan_nr(ts->lchan)); + gsm_lchan2chan_nr(&ts->lchan[0])); } } } -- To view, visit https://gerrit.osmocom.org/11258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8edcb46e887c4db63a425eba89cec4374165763e Gerrit-Change-Number: 11258 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181007/43ec0c43/attachment.htm>