Change in osmo-hlr[master]: store gsup peer upon accepting LU

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Oct 5 15:57:05 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11232 )

Change subject: store gsup peer upon accepting LU
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/11232/3/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/11232/3/src/hlr.c@308
PS3, Line 308: 	     osmo_quote_str((const char*)luop->peer, -1));
Ah sure. Now I'm escaping the string, in case it contains unprintable characters. I'm still assuming it is nul terminated though, because luop->peer doesn't have a len and also seems to assume so... maybe that needs a FIXME to allow null bytes in the GT?



-- 
To view, visit https://gerrit.osmocom.org/11232
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If438664faa5d68404f465f8b2002c6d03bbf3ceb
Gerrit-Change-Number: 11232
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Oct 2018 15:57:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181005/c6f37219/attachment.htm>


More information about the gerrit-log mailing list