Change in osmocom-bb[master]: layer23/l1ctl.c: fix: verify msg length against l1ctl_hdr

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11216 )

Change subject: layer23/l1ctl.c: fix: verify msg length against l1ctl_hdr
......................................................................

layer23/l1ctl.c: fix: verify msg length against l1ctl_hdr

In l1ctl_recv() we actually expect to 'see' the L1CTL header
instead of the DL info header. Let's fix this.

Change-Id: Ic7d017bef04f3c186565d5dade36959df1019bd8
---
M src/host/layer23/src/common/l1ctl.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/layer23/src/common/l1ctl.c b/src/host/layer23/src/common/l1ctl.c
index 39b7f3c..9a3bc0e 100644
--- a/src/host/layer23/src/common/l1ctl.c
+++ b/src/host/layer23/src/common/l1ctl.c
@@ -873,9 +873,8 @@
 {
 	int rc = 0;
 	struct l1ctl_hdr *l1h;
-	struct l1ctl_info_dl *dl;
 
-	if (msgb_l2len(msg) < sizeof(*dl)) {
+	if (msgb_l2len(msg) < sizeof(*l1h)) {
 		LOGP(DL1C, LOGL_ERROR, "Short Layer2 message: %u\n",
 			msgb_l2len(msg));
 		msgb_free(msg);

-- 
To view, visit https://gerrit.osmocom.org/11216
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7d017bef04f3c186565d5dade36959df1019bd8
Gerrit-Change-Number: 11216
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181005/3dc010a4/attachment.htm>