Change in pysim[master]: pySim-prog: Honor international '+' in SMSC number

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11201 )

Change subject: pySim-prog: Honor international '+' in SMSC number
......................................................................


Patch Set 3:

(3 comments)

I left the default value for SMSC as is because I don't know why we chose it and I don't think there is some sane default that we could default to. It would be nice for pySim-prog to not program everything, but only the values that are specified, but that is a patch/discussion for another time.

https://gerrit.osmocom.org/#/c/11201/1/pySim-prog.py
File pySim-prog.py:

https://gerrit.osmocom.org/#/c/11201/1/pySim-prog.py@100
PS1, Line 100: 			help="SMSC number (Start with + for international no.) [default: '00 + country code + 5555']",
> "If it starts with a '+', Type-of-Number is programmed as 'international'" ? […]
Done


https://gerrit.osmocom.org/#/c/11201/1/pySim-prog.py@325
PS1, Line 325: 			if smsc[0] == '+':
> cosmetic: the rest of the file is indented by tabs, the new lines by spaces
Done


https://gerrit.osmocom.org/#/c/11201/1/pySim-prog.py@329
PS1, Line 329: 				raise ValueError('SMSC must be digits only!\n \
> "and optionally start with a '+'" ?
Done



-- 
To view, visit https://gerrit.osmocom.org/11201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia79913f5b0307e9786a5acea75c0811927be2eef
Gerrit-Change-Number: 11201
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Oct 2018 11:22:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181005/62cc9398/attachment.htm>