This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11238 ) Change subject: vty: make 'show calls summary' more userfriendly ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11238/2/src/vty.c File src/vty.c: https://gerrit.osmocom.org/#/c/11238/2/src/vty.c@279 PS2, Line 279: vty_out(vty, "%u | %s | %s | %s%s", call->id, calling, called, state, VTY_NEWLINE); I think you should use the "%5u" or similar notation to ensure thaat the columsn are always aligned. See other examples e.g. in show_cs7_asp_cmd of osmo_ss7_vty.c in libosmo-sccp. Same applies to the state names, and called/calling identity. Other examples are 'show connection' or 'show transaction' in osmo-msc. -- To view, visit https://gerrit.osmocom.org/11238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2092d58d80a34e6083f618593b92bb9e838aa906 Gerrit-Change-Number: 11238 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Fri, 05 Oct 2018 11:20:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181005/bce1a709/attachment.htm>