This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11236 ) Change subject: gsm_08_08: abort complete L3 3 msg gen when no codecs are set ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/11236/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11236/1//COMMIT_MSG@12 PS1, Line 12: due to miss-configuration I think there's something seriously wrong with osmo-bsc, if such "mis-configuration" can happen https://gerrit.osmocom.org/#/c/11236/1/src/osmo-bsc/gsm_08_08.c File src/osmo-bsc/gsm_08_08.c: https://gerrit.osmocom.org/#/c/11236/1/src/osmo-bsc/gsm_08_08.c@501 PS1, Line 501: LOGL_DEBUG debug for something that will effectively make any voice call fail? I think we should definitely have this at NOTICE if not ERROR level. Also, the best is if we don't even allow the user to shoot himself into the foot, i.e. do whatever is needed to avoid being able to create such invalid configurations in the first place. So for sure, we should not permit an empty codec supprt list to be created from the VTY in the MSC section. I guess the only remainig case here is that the BTS supported list (like hard-coded for nanoBTS with no HRv1) doesn't have any intersection with the list specified for the "msc" node in the VTY? Maybe in that case also already print an error message after reading the config file? Or while reading it? Intersect the "msc" codecs with those of each BTS, and print a big fat warning/error message if for any BTS there's no intersection? -- To view, visit https://gerrit.osmocom.org/11236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I119607047a132b75b3077bbe56c97936d8ae6c96 Gerrit-Change-Number: 11236 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Fri, 05 Oct 2018 09:40:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181005/8fc358e2/attachment.htm>