This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11147 )
Change subject: L1CTL_Types: Add support to set L1 Header params during SACCH tx
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/11147/2/library/L1CTL_Types.ttcn
File library/L1CTL_Types.ttcn:
https://gerrit.osmocom.org/#/c/11147/2/library/L1CTL_Types.ttcn@267
PS2, Line 267: type record SACCH_L1_HEADER {
one could argue that this is not a L1CTL specific structure/type and should hence go into GSM_Types or some other place related to GSM specs and not L1CTL. I would probably put it in GSM_RR_Types.
--
To view, visit https://gerrit.osmocom.org/11147
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id014f790ee2ede8ae796c37b1c6b25c4af9034d2
Gerrit-Change-Number: 11147
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Wed, 03 Oct 2018 08:15:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181003/649455e8/attachment.htm>