Change in libosmocore[master]: mncc: Move definitions to header file

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Mon Oct 1 22:55:04 UTC 2018


Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11185 )

Change subject: mncc: Move definitions to header file
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11185/1/src/gsm/mncc.c
File src/gsm/mncc.c:

https://gerrit.osmocom.org/#/c/11185/1/src/gsm/mncc.c@a37
PS1, Line 37: 
Fixing this FIXME FIXME obviously breaks osmo-sip-connector until the duplicated defs are removed from mncc_protocol.h in that project. 
I don't know if it will break anything else. Just thought it'd be nice to remove this code duplication sooner rather than later.



-- 
To view, visit https://gerrit.osmocom.org/11185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62bc025369bd9ee9b134e064a8364aa4bd5de16e
Gerrit-Change-Number: 11185
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Comment-Date: Mon, 01 Oct 2018 22:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181001/38e411a9/attachment.htm>


More information about the gerrit-log mailing list