This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12045 ) Change subject: gerrit-verifications/master-builds: with_manuals ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/12045/2/jobs/gerrit-verifications.yml File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/#/c/12045/2/jobs/gerrit-verifications.yml@97 PS2, Line 97: (FIRMWARE_VERSION == "femtobts_v2.7" && BTS_MODEL == "sysmo" && with_manuals == True) || > I had this first: […] Ah indeed, makes sense then. https://gerrit.osmocom.org/#/c/12045/2/jobs/master-builds.yml File jobs/master-builds.yml: https://gerrit.osmocom.org/#/c/12045/2/jobs/master-builds.yml@206 PS2, Line 206: cmd: GTP="$GTP" ./contrib/jenkins.sh --publish > I think the […] I know I wrote --publish is my previous comment, but I actually think it makes sense to have --publish being passed inside jenkins.sh based on MANUALS env var value (because we only want to use --publish when we build the manuals right?). Ok, fine not definding it as a2: !!python/tuple ["--enable-manuals", "--disable-manuals"] , but still makes sense to call it in caps MANUALS (or WITH_MANUALS), and pass it as an envar and use it in jenkins.sh (like you do in the commit you shared in your comment). AFAIU the var is not redundant because it is not exported, so you'd need to either export GTP="$GTP" before calling jenkins.sh or, do it as it is done now. If that's not the case, then let's remove the GTP="$GTP" fomr verywhere, but I'd at least investigate git log why do wo do that. -- To view, visit https://gerrit.osmocom.org/12045 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0643b17a6be6e86e281b50d78dd7a6858cf99ee Gerrit-Change-Number: 12045 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Fri, 30 Nov 2018 16:10:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/12bfa466/attachment.htm>