Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 30 11:56:52 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11827 )

Change subject: LCLS, TS 29.205: add GCR routines
......................................................................


Patch Set 9: Code-Review-1

(5 comments)

https://gerrit.osmocom.org/#/c/11827/9/src/gsm/gsm29_205.c
File src/gsm/gsm29_205.c:

https://gerrit.osmocom.org/#/c/11827/9/src/gsm/gsm29_205.c@76
PS9, Line 76: 		return -E2BIG;
probably another error would be better here. returning "too big" when size is too small is really confusing.


https://gerrit.osmocom.org/#/c/11827/9/src/gsm/gsm29_205.c@82
PS9, Line 82: 	parsed += (2 + 1);
parenthesis can be dropped here.


https://gerrit.osmocom.org/#/c/11827/9/src/gsm/gsm29_205.c@85
PS9, Line 85: 		return -EBADF;
Doesn't look like EBADF is a good error to return here. -EINVAL maybe?


https://gerrit.osmocom.org/#/c/11827/9/src/gsm/libosmogsm.map
File src/gsm/libosmogsm.map:

https://gerrit.osmocom.org/#/c/11827/9/src/gsm/libosmogsm.map@147
PS9, Line 147: gsm29205_enc_gcr;
I know not everything is perfectly sorted, but let's try to keep it as sorted as possible, so move these to line 225


https://gerrit.osmocom.org/#/c/11827/9/tests/gsm29205/gsm29205_test.c
File tests/gsm29205/gsm29205_test.c:

https://gerrit.osmocom.org/#/c/11827/9/tests/gsm29205/gsm29205_test.c@64
PS9, Line 64: 		printf("decoding failed: %s [%s]\n", strerror(-rc), msgb_hexdump(msg));
All these should exit, or at least return.



-- 
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf
Gerrit-Change-Number: 11827
Gerrit-PatchSet: 9
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Nov 2018 11:56:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/eb931989/attachment.htm>


More information about the gerrit-log mailing list