Change in osmo-bts[master]: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 29 19:32:57 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11932 )

Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

(I won't pretend to know this code)

https://gerrit.osmocom.org/#/c/11932/4//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11932/4//COMMIT_MSG@10
PS4, Line 10: into account if TRX succeeded or failed to set the TS:
are we talking bootstrapping the BTS in the beginning?


https://gerrit.osmocom.org/#/c/11932/4//COMMIT_MSG@32
PS4, Line 32: 20181123044720705 DTRX <000b> trx_if.c:492 Response message: 'RSP SETSLOT 0 6 1'
since you're posting a lot of logging in commit logs lately...

how about dropping the timestamp and the category-hex, instead adding the loglevel as explicit string, and either omitting the src line or putting it in the end?

 logging print level 1
 logging print category 1
 logging print category-hex 0
 logging print file basename last

(timestamp can be dropped by editor, like Ctrl-V in vim)



-- 
To view, visit https://gerrit.osmocom.org/11932
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I888de761b65c3ea8bfe623fcf009f3b2b57c926c
Gerrit-Change-Number: 11932
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 19:32:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/5ff997ff/attachment.htm>


More information about the gerrit-log mailing list