This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11996 ) Change subject: bsc: lchan_fsm: Fix invalid duplicated transition ...................................................................... Patch Set 2: Code-Review+2 (1 comment) These are the reverberating release event avalanches that one typically gets when N components plugged together each need to tell all other components to tear down in case anything goes wrong. When writing, I merely was interested in being sure that each component *does* signal a release to the others and that a repeated event is not harmful. If you figured out how, then fine with me to make the log a bit shorter, too. https://gerrit.osmocom.org/#/c/11996/2/src/osmo-bsc/lchan_fsm.c File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/#/c/11996/2/src/osmo-bsc/lchan_fsm.c@988 PS2, Line 988: if (!sapis && !lchan->fi_rtp && fi->state == LCHAN_ST_WAIT_RLL_RTP_RELEASED) maybe rather "&& fi->state != LCHAN_ST_WAIT_BEFORE_RF_RELEASE"? ok, thinking, if it already went to some error state for whatever weird reasons we shouldn't transition back... yeah ok. (I often have a desire to trigger a state transition only if it differs from the current state. Was thinking to add osmo_fsm_ API for this) -- To view, visit https://gerrit.osmocom.org/11996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d95bbd8244cc8e9c1cfb6fe0f76148332386a3d Gerrit-Change-Number: 11996 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Thu, 29 Nov 2018 19:20:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/f3adbe4a/attachment.htm>