Change in osmo-bsc[master]: Fix ts_for_each_lchan iteration for dynamic TS in process of being PD...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 29 19:00:23 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11957 )

Change subject: Fix ts_for_each_lchan iteration for dynamic TS in process of being PDCH deactivated
......................................................................


Patch Set 3: Code-Review+2

(3 comments)

https://gerrit.osmocom.org/#/c/11957/3//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11957/3//COMMIT_MSG@7
PS3, Line 7: Fix ts_for_each_lchan iteration for dynamic TS in process of being PDCH deactivated
(ideas to make it shorter... 'fix lchan iteration for dyn TS during PDCH Deact')


https://gerrit.osmocom.org/#/c/11957/3//COMMIT_MSG@9
PS3, Line 9: In general PDCH channels are not handled as lchans in BTS (lchan_fsm.c),
"BTS (lchan_fsm.c)"???


https://gerrit.osmocom.org/#/c/11957/3//COMMIT_MSG@11
PS3, Line 11: being used.
I believe this commit log message has 'I wrote a long letter because I didn't have the time to make it shorter' syndrome.

"To make sure that a dyn TS error signals an error to all waiting lchans, make sure to iterate all potential lchans even if pchan_is == GSM_PCHAN_PDCH and no lchans are really enabled yet.

For example, previously, a PDCH Deact NACK failed to signal waiting lchans, as ts_for_each_lchan() iterates only lchans that make sense with the current pchan mode."

That's all of it, right?



-- 
To view, visit https://gerrit.osmocom.org/11957
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cedb77d6578597f1febab36c54b2ee427c7a4a2
Gerrit-Change-Number: 11957
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Nov 2018 19:00:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/fb8e7b04/attachment.htm>


More information about the gerrit-log mailing list