Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_lu_and_ss_session_timeout

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Nov 29 14:59:03 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11985 )

Change subject: MSC_Tests.ttcn: introduce TC_lu_and_ss_session_timeout
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/11985/3/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11985/3/msc/MSC_Tests.ttcn@2742
PS3, Line 2742: 		cause := *, /* TODO: expect some specific value */
> If a value shall be sent and you don't yet care which, then maybe '?' would be better. […]
The problem is that libosmogsm's buggy GSM 04.80 API doesn't
allow one to encode optional cause TLV, so it's omitted for now.

As soon as we improve the API, it would be possible to encode
some specific value. But this is not the only problem. See below.


https://gerrit.osmocom.org/#/c/11985/3/msc/MSC_Tests.ttcn@2749
PS3, Line 2749: 		cause := ?); /* TODO: expect some specific value */
> aha! :)
It's not clean (yet) which cause value should be used in case
of session timeout expiry. The session timeout is a specific
feature of *our GSM 09.11 implementation* => it isn't not covered
by the specs.

Moreover, due to historical reasons, the generic cause IE in GSUP
is not generic at all - it's limited by 'gsm48_gmm_cause' enum.

After all, the main idea of this test case is to verify if OsmoMSC
is capable to terminate SS/USSD transactions due to timeout expiry,
and the exact cause values are not that important for now.



-- 
To view, visit https://gerrit.osmocom.org/11985
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e1791773d56617172ae27a46889a1ae4d400e2f
Gerrit-Change-Number: 11985
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 14:59:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/15010831/attachment.htm>


More information about the gerrit-log mailing list