Change in osmo-bsc[master]: bsc: lchan_rtp_fsm: Remove duplicate LCHAN_EV_RTP_RELEASED event

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 29 14:34:11 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11993 )

Change subject: bsc: lchan_rtp_fsm: Remove duplicate LCHAN_EV_RTP_RELEASED event
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/11993/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11993/1//COMMIT_MSG@23
PS1, Line 23: 20181128193707330 DAS <0012> fsm.c:381 assignment(conn4_0-0-6-TCH_F_PDCHasPDCH-0)[0x6120000024a0]{WAIT_LCHAN_ACTIVE}: Deallocated
you *could* make this a bit more readable next time :)


https://gerrit.osmocom.org/#/c/11993/1/src/osmo-bsc/lchan_rtp_fsm.c
File src/osmo-bsc/lchan_rtp_fsm.c:

https://gerrit.osmocom.org/#/c/11993/1/src/osmo-bsc/lchan_rtp_fsm.c@a742
PS1, Line 742: 
while it is true that this is normally a duplicate event, it does make sure that in case the RTP hits a cleanup for any odd reason, we will notify the lchan of it.

Say something went wrong during MGCP or RTP delivery, or the lchan_rtp fi gets terminated out of the blue... (If the lchan_rtp FSM gets deallocated, the lchan must be *guaranteed* to no longer reference the lchan_rtp fi pointer.)

Maybe rather something like make this conditional on the current lchan state, or some flag that tells us whether we've already told the lchan that RTP was released? Or see whether the lchan still points at this fi?

Simplest is to just keep the duplicate event? It's not harmful...



-- 
To view, visit https://gerrit.osmocom.org/11993
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e95a21e5a5ec6c35b1ab20b7a642fd7eb81e556
Gerrit-Change-Number: 11993
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Nov 2018 14:34:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/7851176c/attachment.htm>


More information about the gerrit-log mailing list