Change in osmo-trx[master]: lms: Use a default Tx gain value of 64 dB.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Nov 29 13:18:05 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12008 )

Change subject: lms: Use a default Tx gain value of 64 dB.
......................................................................


Patch Set 2:

It seems default (having no "tx-attenuation" line in osmo-bts VTY) ends up setting TxGain to 73Db with this patch applied:

-- Transceiver active with 1 channel(s)
Thu Nov 29 14:09:49 2018 DMAIN <0000> Transceiver.cpp:724 [tid=139633425098496] command is POWEROFF
Thu Nov 29 14:09:49 2018 DMAIN <0000> Transceiver.cpp:724 [tid=139633425098496] command is RXTUNE 1782200
Thu Nov 29 14:09:50 2018 DMAIN <0000> Transceiver.cpp:724 [tid=139633425098496] command is TXTUNE 1877200
Thu Nov 29 14:09:50 2018 DMAIN <0000> Transceiver.cpp:724 [tid=139633425098496] command is SETTSC 7
Thu Nov 29 14:09:50 2018 DMAIN <0000> Transceiver.cpp:826 [tid=139633425098496] Changing TSC from 0 to 7
Thu Nov 29 14:09:50 2018 DMAIN <0000> Transceiver.cpp:724 [tid=139633425098496] command is POWERON
Thu Nov 29 14:09:50 2018 DMAIN <0000> Transceiver.cpp:253 [tid=139633425098496] Starting the transceiver
Thu Nov 29 14:09:50 2018 DMAIN <0000> radioInterface.cpp:169 [tid=139633425098496] Starting radio device
Thu Nov 29 14:09:50 2018 DDEV <0001> LMSDevice.cpp:212 [tid=139633425098496] starting LMS...
Thu Nov 29 14:09:50 2018 DDEV <0001> LMSDevice.cpp:316 [tid=139633425098496] Setting TX gain to 64 dB.
Thu Nov 29 14:09:50 2018 DDEV <0001> LMSDevice.cpp:336 [tid=139633425098496] Setting RX gain to 36.5 dB.
Thu Nov 29 14:09:50 2018 DDEV <0001> LMSDevice.cpp:383 [tid=139633425098496] Initial timestamp 27500
Thu Nov 29 14:09:50 2018 DMAIN <0000> radioInterface.cpp:190 [tid=139633425098496] Radio started
Thu Nov 29 14:09:50 2018 DMAIN <0000> Threads.cpp:116 [tid=139633422538496] Thread 139633422538496 (task 1885) set name: TxLower
Thu Nov 29 14:09:50 2018 DMAIN <0000> Threads.cpp:116 [tid=139633422444288] Thread 139633422444288 (task 1886) set name: RxLower
Thu Nov 29 14:09:50 2018 DMAIN <0000> Threads.cpp:116 [tid=139633422284544] Thread 139633422284544 (task 1887) set name: RxUpper0
Thu Nov 29 14:09:50 2018 DMAIN <0000> Threads.cpp:116 [tid=139633422157568] Thread 139633422157568 (task 1888) set name: TxUpper0
Thu Nov 29 14:09:50 2018 DMAIN <0000> Transceiver.cpp:724 [tid=139633425098496] command is SETRXGAIN 1
Thu Nov 29 14:09:50 2018 DDEV <0001> LMSDevice.cpp:336 [tid=139633425098496] Setting RX gain to 1 dB.
Thu Nov 29 14:09:50 2018 DMAIN <0000> Transceiver.cpp:724 [tid=139633425098496] command is SETPOWER 0
Thu Nov 29 14:09:50 2018 DDEV <0001> LMSDevice.cpp:316 [tid=139633425098496] Setting TX gain to 73 dB.


So basically SETPOWER 0 means apply 0 attenuation, which gets passed this way:
rfGain = mRadio->setTxGain(mRadio->maxTxGain() - (double) atten, chan);

So I think we should set maxTxGain() to 64dB instead of 73dB for it to be applied nicely.


-- 
To view, visit https://gerrit.osmocom.org/12008
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id018b27b1d8a2f48d60b29e688583c9a5ac49a81
Gerrit-Change-Number: 12008
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Nov 2018 13:18:05 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/ff055643/attachment.htm>


More information about the gerrit-log mailing list