Change in osmo-bsc[master]: bsc: timeslot_fsm: Fix possible skip of some lchans in ts_terminate_l...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Nov 28 16:34:15 UTC 2018


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11982


Change subject: bsc: timeslot_fsm: Fix possible skip of some lchans in ts_terminate_lchan_fsms
......................................................................

bsc: timeslot_fsm: Fix possible skip of some lchans in ts_terminate_lchan_fsms

If TS is in state changing from PDCH->TCH, the TCH lchan provoking the
switch would be skipped and not terminated before this patch.

See osmo-bsc I9cedb77d6578597f1febab36c54b2ee427c7a4a2 for similar
extensive explanation.

Change-Id: I9dc2a6e5b15376d049bd2ac5ddfa24340771b5c8
---
M src/osmo-bsc/timeslot_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/11982/1

diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c
index 764c20c..25c6977 100644
--- a/src/osmo-bsc/timeslot_fsm.c
+++ b/src/osmo-bsc/timeslot_fsm.c
@@ -135,7 +135,7 @@
 {
 	struct gsm_lchan *lchan;
 
-	ts_for_each_lchan(lchan, ts) {
+	ts_for_each_lchan_slot(lchan, ts) {
 		osmo_fsm_inst_term(lchan->fi, OSMO_FSM_TERM_REQUEST, NULL);
 	}
 }

-- 
To view, visit https://gerrit.osmocom.org/11982
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9dc2a6e5b15376d049bd2ac5ddfa24340771b5c8
Gerrit-Change-Number: 11982
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181128/48d11204/attachment.htm>


More information about the gerrit-log mailing list