Change in osmo-bsc[master]: bsc: timeslot_fsm: ts_is_pchan_switching: Set correct target pchan fo...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Nov 27 17:48:11 UTC 2018


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11954


Change subject: bsc: timeslot_fsm: ts_is_pchan_switching: Set correct target pchan for IPA dynts
......................................................................

bsc: timeslot_fsm: ts_is_pchan_switching: Set correct target pchan for IPA dynts

For IPA dynamic TS, we never go to NONE but deactivating PDCH
automatically sets it as TCH/F, as can also be seen in
ts_fsm_wait_pdch_deact.

Change-Id: Ib03e5a91438a5b74a04e69f81fab565842b02b66
---
M src/osmo-bsc/timeslot_fsm.c
1 file changed, 10 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/54/11954/1

diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c
index fc25460..011b810 100644
--- a/src/osmo-bsc/timeslot_fsm.c
+++ b/src/osmo-bsc/timeslot_fsm.c
@@ -897,8 +897,17 @@
 	case TS_ST_WAIT_PDCH_DEACT:
 		/* If we were switching to a specific pchan kind, an lchan would be waiting. So this must
 		 * be NONE then. */
-		if (target_pchan)
+		if (target_pchan) {
 			*target_pchan = GSM_PCHAN_NONE;
+			switch (ts->pchan_on_init) {
+			case GSM_PCHAN_TCH_F_TCH_H_PDCH:
+				*target_pchan = GSM_PCHAN_NONE;
+				break;
+			case GSM_PCHAN_TCH_F_PDCH:
+				*target_pchan = GSM_PCHAN_TCH_F;
+				break;
+			}
+		}
 		return true;
 
 	default:

-- 
To view, visit https://gerrit.osmocom.org/11954
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib03e5a91438a5b74a04e69f81fab565842b02b66
Gerrit-Change-Number: 11954
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181127/b62b367f/attachment.htm>


More information about the gerrit-log mailing list