This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/11943 ) Change subject: fix file descriptor leak in osysmon_file_read ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Just a minor thing though - can be merged either way. https://gerrit.osmocom.org/#/c/11943/2/osysmon_file.c File osysmon_file.c: https://gerrit.osmocom.org/#/c/11943/2/osysmon_file.c@80 PS2, Line 80: char *s, *nl; Seems like you don't need new variable. https://gerrit.osmocom.org/#/c/11943/2/osysmon_file.c@93 PS2, Line 93: } s is not used after here and nl is not used before. -- To view, visit https://gerrit.osmocom.org/11943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1b5734748438c6d785cd96dfa9af6303cd102da Gerrit-Change-Number: 11943 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Comment-Date: Tue, 27 Nov 2018 15:05:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181127/9b6a8107/attachment.htm>