Change in osmo-bsc[master]: send Immediate Assignment Reject only before Immediate Assignment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Nov 27 07:50:08 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11940 )

Change subject: send Immediate Assignment Reject only before Immediate Assignment
......................................................................


Patch Set 2:

(2 comments)

Oh, it has been already merged :/

https://gerrit.osmocom.org/#/c/11940/2/src/osmo-bsc/lchan_fsm.c
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/#/c/11940/2/src/osmo-bsc/lchan_fsm.c@101
PS2, Line 101: LOGL_ERROR
As I pointed out in OS#3709, let's use LOGL_NOTICE.


https://gerrit.osmocom.org/#/c/11940/2/src/osmo-bsc/lchan_fsm.c@102
PS2, Line 102: lchan activation failed
As was also pointed out in OS#3709, at this point the
activation was successful. We could debug something like:

  LOG_LCHAN(lchan, LOGL_NOTICE, "No response to Immediate Assignment, tearing down the lchan\n");

or not to print anything at all.



-- 
To view, visit https://gerrit.osmocom.org/11940
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad094d272254d7aee9b0a676201d4ed8cd727ca
Gerrit-Change-Number: 11940
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 27 Nov 2018 07:50:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181127/1d907e5f/attachment.htm>


More information about the gerrit-log mailing list